Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js: add moduleInfo method #2057

Merged
merged 1 commit into from
Sep 14, 2024
Merged

js: add moduleInfo method #2057

merged 1 commit into from
Sep 14, 2024

Conversation

jeffpeng3
Copy link
Contributor

@jeffpeng3 jeffpeng3 commented Sep 11, 2024 •
edited
Loading

Add a ksu.moduleInfo() in JS.
resolves #1571

test module's index.html
image

The test module:
moduleInfo_test.zip

test module's result:
image

@tiann
Copy link
Owner

tiann commented Sep 14, 2024

I prefer to add a moduleInfo method, and return id, moduleDir, etc..

@jeffpeng3
Copy link
Contributor Author

I'd like to know what you think should be there, such as whether the version needs to be provided, etc.

@tiann
Copy link
Owner

tiann commented Sep 14, 2024

You can refer the ksud module list

@jeffpeng3 jeffpeng3 changed the title js: add moduleDir method js: add moduleInfo method Sep 14, 2024
@jeffpeng3
Copy link
Contributor Author

jeffpeng3 commented Sep 14, 2024 •
edited
Loading

I've rewritten it as moduleInfo.

It referenced me.weishu.kernelsu.ui.util.listModules and filtered out the current module's data, merged in the moduleDir and output it as a json string.

This should work the way you said and rely on the output of the ksud module list.

@tiann tiann merged commit ac20b76 into tiann:main Sep 14, 2024
14 checks passed
ananjaser1211 added a commit to ananjaser1211/KernelSU that referenced this pull request Sep 20, 2024
@ananjaser1211
Revert "js: add moduleInfo method (tiann#2057)"
8d396ee 
This reverts commit ac20b76.
kutemeikito added a commit to kutemeikito/KernelSU that referenced this pull request Sep 23, 2024
@kutemeikito
Merge branch 'main' of https://github.com/tiann/KernelSU
33b9ed3 
* 'main' of https://github.com/tiann/KernelSU:
  js: add moduleInfo method (tiann#2057)
  Update doc for zh_CN (tiann#2049)
  Translations update from Hosted Weblate (tiann#2008)
  build(deps): bump the npm group across 1 directory with 24 updates (tiann#2040)
  kernel: Relax dentry_path_raw compare in core_hook (tiann#2041)
  build(deps): bump peter-evans/create-pull-request from 6 to 7 in the actions group (tiann#2031)
  website/docs: add N0Kernel and NOVA kernels (tiann#2012)
  Add Italian translations for README (tiann#2018)

Signed-off-by: Edwiin Kusuma Jaya <kutemeikito0905@gmail.com>
xxmustafacooTR pushed a commit to xxmustafacooTR/KernelSU that referenced this pull request Sep 25, 2024
@jeffpeng3 @xxmustafacooTR
js: add moduleInfo method (tiann#2057)
f179fe7 
Add a `ksu.moduleInfo()` in JS.
resolves tiann#1571

test module's index.html

![image](https://github.com/user-attachments/assets/39920606-452c-4b19-abca-967c25146d6a)

The test module:

[moduleInfo_test.zip](https://github.com/user-attachments/files/17001977/moduleInfo_test.zip)

test module's result:

![image](https://github.com/user-attachments/assets/9dbbd2e8-f7ea-418f-b545-66d33ce1b3ae)
LeCmnGend pushed a commit to LeCmnGend/KernelSU that referenced this pull request Sep 29, 2024
@jeffpeng3 @LeCmnGend
js: add moduleInfo method (tiann#2057)
9d1c530 
Add a `ksu.moduleInfo()` in JS.
resolves tiann#1571

test module's index.html

![image](https://github.com/user-attachments/assets/39920606-452c-4b19-abca-967c25146d6a)

The test module:

[moduleInfo_test.zip](https://github.com/user-attachments/files/17001977/moduleInfo_test.zip)

test module's result:

![image](https://github.com/user-attachments/assets/9dbbd2e8-f7ea-418f-b545-66d33ce1b3ae)
fukiame pushed a commit to TelegramAt25/KernelSU-shukusai that referenced this pull request Oct 3, 2024
@jeffpeng3 @fukiame
js: add moduleInfo method (tiann#2057)
25f2d94 
Add a `ksu.moduleInfo()` in JS.
resolves tiann#1571

test module's index.html

![image](https://github.com/user-attachments/assets/39920606-452c-4b19-abca-967c25146d6a)

The test module:

[moduleInfo_test.zip](https://github.com/user-attachments/files/17001977/moduleInfo_test.zip)

test module's result:

![image](https://github.com/user-attachments/assets/9dbbd2e8-f7ea-418f-b545-66d33ce1b3ae)
backslashxx pushed a commit to backslashxx/KernelSU that referenced this pull request Nov 14, 2024
@jeffpeng3 @backslashxx
js: add moduleInfo method (tiann#2057)
d393e92 
Add a `ksu.moduleInfo()` in JS.
resolves tiann#1571

test module's index.html

![image](https://github.com/user-attachments/assets/39920606-452c-4b19-abca-967c25146d6a)

The test module:

[moduleInfo_test.zip](https://github.com/user-attachments/files/17001977/moduleInfo_test.zip)

test module's result:

![image](https://github.com/user-attachments/assets/9dbbd2e8-f7ea-418f-b545-66d33ce1b3ae)
backslashxx pushed a commit to backslashxx/KernelSU that referenced this pull request Dec 7, 2024
@jeffpeng3 @backslashxx
js: add moduleInfo method (tiann#2057)
88268d3 
Add a `ksu.moduleInfo()` in JS.
resolves tiann#1571

test module's index.html

![image](https://github.com/user-attachments/assets/39920606-452c-4b19-abca-967c25146d6a)

The test module:

[moduleInfo_test.zip](https://github.com/user-attachments/files/17001977/moduleInfo_test.zip)

test module's result:

![image](https://github.com/user-attachments/assets/9dbbd2e8-f7ea-418f-b545-66d33ce1b3ae)
xeunBin pushed a commit to xeunBin/KernelSU-Next-4.14 that referenced this pull request Jan 19, 2025
@jeffpeng3 @xeunBin
js: add moduleInfo method (tiann#2057)
ec11140 
Add a `ksu.moduleInfo()` in JS.
resolves tiann#1571

test module's index.html

![image](https://github.com/user-attachments/assets/39920606-452c-4b19-abca-967c25146d6a)

The test module:

[moduleInfo_test.zip](https://github.com/user-attachments/files/17001977/moduleInfo_test.zip)

test module's result:

![image](https://github.com/user-attachments/assets/9dbbd2e8-f7ea-418f-b545-66d33ce1b3ae)
backslashxx pushed a commit to backslashxx/KernelSU that referenced this pull request Jan 29, 2025
@jeffpeng3 @backslashxx
js: add moduleInfo method (tiann#2057)
008958a 
Add a `ksu.moduleInfo()` in JS.
resolves tiann#1571

test module's index.html

![image](https://github.com/user-attachments/assets/39920606-452c-4b19-abca-967c25146d6a)

The test module:

[moduleInfo_test.zip](https://github.com/user-attachments/files/17001977/moduleInfo_test.zip)

test module's result:

![image](https://github.com/user-attachments/assets/9dbbd2e8-f7ea-418f-b545-66d33ce1b3ae)
backslashxx pushed a commit to backslashxx/KernelSU that referenced this pull request Feb 3, 2025
@jeffpeng3 @backslashxx
js: add moduleInfo method (tiann#2057)
2f0e514 
Add a `ksu.moduleInfo()` in JS.
resolves tiann#1571

test module's index.html

![image](https://github.com/user-attachments/assets/39920606-452c-4b19-abca-967c25146d6a)

The test module:

[moduleInfo_test.zip](https://github.com/user-attachments/files/17001977/moduleInfo_test.zip)

test module's result:

![image](https://github.com/user-attachments/assets/9dbbd2e8-f7ea-418f-b545-66d33ce1b3ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiann tiann tiann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]webui中是否能增加获取当前模块根目录的功能
2 participants
@jeffpeng3 @tiann