-
-
Notifications
You must be signed in to change notification settings - Fork 164
fix(web): 修复历史消息加载时的滚动位置恢复问题 #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0x7551
wants to merge
6
commits into
tiann:main
Choose a base branch
from
0x7551:fix/scroll-position-restoration-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−4
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b32446e
fix(web): prevent autoScroll from interfering with history load scrol…
94746b5
debug(web): add console logs to diagnose scroll position restoration
48ea4e1
fix(web): wait for DOM update before restoring scroll position
79fc79c
chore(web): remove debug console logs from scroll position fix
adabc98
fix(web): improve scroll position restoration robustness
08f28c8
fix(web): defer autoScroll state updates to avoid DOM conflicts
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[MAJOR] Correctness 强制开启 autoScroll 导致滚动位置被重置
Why this is a problem: 在
useLayoutEffect未触发时,当前实现会无条件setAutoScrollEnabled(true),即便用户在加载前并不在底部,也会被强制打开自动滚动,导致加载历史后滚动跳到底部/位置丢失。Suggested fix: