Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform/AMD: Adds local stuart_ci_build support #203

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 114 additions & 0 deletions Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.ci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
## @file
# CI configuration for AmdMinBoardPkg
#
# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
"PrEval": {
"DscPath": "AmdMinBoardPkg.dsc",
},
## options defined .pytool/Plugin/LicenseCheck
"LicenseCheck": {
"IgnoreFiles": []
},
"EccCheck": {
## Exception sample looks like below:
## "ExceptionList": [
## "<ErrorID>", "<KeyWord>"
## ]
"ExceptionList": [
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
]
},
## options defined ci/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "AmdMinBoardPkg.dsc"
},
## options defined ci/Plugin/HostUnitTestCompilerPlugin
"HostUnitTestCompilerPlugin": {
"DscPath": ""
},

## options defined ci/Plugin/CharEncodingCheck
"CharEncodingCheck": {
"IgnoreFiles": []
},

## options defined ci/Plugin/DependencyCheck
"DependencyCheck": {
"AcceptableDependencies": [
"AmdMinBoardPkg/AmdMinBoardPkg.dec",
"AmdPlatformPkg/AmdPlatformPkg.dec",
"BoardModulePkg/BoardModulePkg.dec",
"DynamicTablesPkg/DynamicTablesPkg.dec",
"IpmiFeaturePkg/IpmiFeaturePkg.dec",
"ManageabilityPkg/ManageabilityPkg.dec",
"MdeModulePkg/MdeModulePkg.dec",
"MdePkg/MdePkg.dec",
"MinPlatformPkg/MinPlatformPkg.dec",
"PcAtChipsetPkg/PcAtChipsetPkg.dec",
"SecurityPkg/SecurityPkg.dec",
"UefiCpuPkg/UefiCpuPkg.dec",
"UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
],
# For host based unit tests
"AcceptableDependencies-HOST_APPLICATION":[
"UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
],
# For UEFI shell based apps
"AcceptableDependencies-UEFI_APPLICATION":[],
"IgnoreInf": []
},

## options defined ci/Plugin/DscCompleteCheck
"DscCompleteCheck": {
"IgnoreInf": [],
"DscPath": "AmdMinBoardPkg.dsc"
},
## options defined ci/Plugin/HostUnitTestDscCompleteCheck
"HostUnitTestDscCompleteCheck": {
"IgnoreInf": [""],
## "DscPath": "Test/AmdMinBoardPkgHostTest.dsc"
},

## options defined ci/Plugin/GuidCheck
"GuidCheck": {
"IgnoreGuidName": [],
"IgnoreGuidValue": [],
"IgnoreFoldersAndFiles": [],
"IgnoreDuplicates": []
},

## options defined ci/Plugin/LibraryClassCheck
"LibraryClassCheck": {
"IgnoreHeaderFile": []
},

## options defined ci/Plugin/SpellCheck
"SpellCheck": {
"AuditOnly": False, # If True, only audit the files, do not fail the build
"IgnoreStandardPaths": [ # Standard Plugin defined paths that should be ignore
## "*.c", "*.asm", "*.h", "*.nasm", "*.s", "*.asl", "*.inf"
],
"IgnoreFiles": [ # use gitignore syntax to ignore errors in matching files
],
"ExtendWords": [ # words to extend to the dictionary for this package
"acpitable",
"agesa",
"lapic",
"pciexbar",
"rdtsc"
],
"AdditionalIncludePaths": [] # Additional paths to spell check relative to package root (wildcards supported)
},
"DebugMacroCheck": {
"StringSubstitutions": {
# Reason: Expansion of macro that contains a print specifier.
# AMD can write its own print specifier.
# "AMD_PRINT": "0x%lx"
}
}
}
4 changes: 2 additions & 2 deletions Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
PLATFORM_NAME = AmdMinBoardPkg
PLATFORM_VERSION = 0.1
OUTPUT_DIRECTORY = Build/$(PLATFORM_NAME)
BUILD_TARGETS = DEBUG | RELEASE | NOOPT
SUPPORTED_ARCHITECTURES = IA32 | X64
BUILD_TARGETS = DEBUG|RELEASE|NOOPT
SUPPORTED_ARCHITECTURES = IA32|X64

[Packages]
AmdMinBoardPkg/AmdMinBoardPkg.dec
Expand Down
139 changes: 139 additions & 0 deletions Platform/AMD/AmdPlatformPkg/AmdPlatformPkg.ci.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,139 @@
## @file
# CI configuration for AmdPlatformPkg
#
# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent
##
{
"PrEval": {
"DscPath": "AmdPlatformPkg.dsc",
},
## options defined .pytool/Plugin/LicenseCheck
"LicenseCheck": {
"IgnoreFiles": []
},
"EccCheck": {
## Exception sample looks like below:
## "ExceptionList": [
## "<ErrorID>", "<KeyWord>"
## ]
"ExceptionList": [
],
## Both file path and directory path are accepted.
"IgnoreFiles": [
]
},
## options defined ci/Plugin/CompilerPlugin
"CompilerPlugin": {
"DscPath": "AmdPlatformPkg.dsc"
},
## options defined ci/Plugin/HostUnitTestCompilerPlugin
"HostUnitTestCompilerPlugin": {
"DscPath": ""
},

## options defined ci/Plugin/CharEncodingCheck
"CharEncodingCheck": {
"IgnoreFiles": []
},

## options defined ci/Plugin/DependencyCheck
"DependencyCheck": {
"AcceptableDependencies": [
"AgesaModulePkg/AgesaCommonModulePkg.dec",
"AgesaModulePkg/AgesaEdk2Pkg.dec",
"AgesaModulePkg/AgesaModuleFchPkg.dec",
"AgesaModulePkg/AgesaModuleNbioPkg.dec",
"AgesaModulePkg/AgesaModulePspPkg.dec",
"AgesaPkg/AgesaPkg.dec",
"AmdCpmPkg/AmdCpmPkg.dec",
"AmdMinBoardPkg/AmdMinBoardPkg.dec",
"AmdPlatformPkg/AmdPlatformPkg.dec",
"BoardModulePkg/BoardModulePkg.dec",
"DynamicTablesPkg/DynamicTablesPkg.dec",
"IpmiFeaturePkg/IpmiFeaturePkg.dec",
"MdeModulePkg/MdeModulePkg.dec",
"MdePkg/MdePkg.dec",
"MinPlatformPkg/MinPlatformPkg.dec",
"PcAtChipsetPkg/PcAtChipsetPkg.dec",
"SignedCapsulePkg/SignedCapsulePkg.dec",
"SecurityPkg/SecurityPkg.dec",
"UefiCpuPkg/UefiCpuPkg.dec",
"UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
],
# For host based unit tests
"AcceptableDependencies-HOST_APPLICATION":[
"UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
],
# For UEFI shell based apps
"AcceptableDependencies-UEFI_APPLICATION":[],
"IgnoreInf": []
},

## options defined ci/Plugin/DscCompleteCheck
"DscCompleteCheck": {
"IgnoreInf": [
],
"DscPath": "AmdPlatformPkg.dsc"
},
## options defined ci/Plugin/HostUnitTestDscCompleteCheck
"HostUnitTestDscCompleteCheck": {
"IgnoreInf": [""],
## "DscPath": "Test/AmdPlatformPkgHostTest.dsc"
},

## options defined ci/Plugin/GuidCheck
"GuidCheck": {
"IgnoreGuidName": [],
"IgnoreGuidValue": [],
"IgnoreFoldersAndFiles": [],
"IgnoreDuplicates": []
},

## options defined ci/Plugin/LibraryClassCheck
"LibraryClassCheck": {
"IgnoreHeaderFile": []
},

## options defined ci/Plugin/SpellCheck
"SpellCheck": {
"AuditOnly": False, # If True, only audit the files, do not fail the build
"IgnoreStandardPaths": [ # Standard Plugin defined paths that should be ignore
## "*.c", "*.asm", "*.h", "*.nasm", "*.s", "*.asl", "*.inf"
],
"IgnoreFiles": [ # use gitignore syntax to ignore errors in matching files
],
"ExtendWords": [ # words to extend to the dictionary for this package
"agesa",
"defaultdb",
"defaultdbx",
"deviceid",
"eisaid",
"flashid",
"iomux",
"jedec",
"oemid",
"pmioa",
"ppread",
"rdsfdp",
"smdbg",
"ssdtproc",
"eeprom",
"gpiox",
"agpio",
"sgpio",
"acpimmio",
"glink",
"ehci's",
"uhci's"
],
"AdditionalIncludePaths": [] # Additional paths to spell check relative to package root (wildcards supported)
},
"DebugMacroCheck": {
"StringSubstitutions": {
# Reason: Expansion of macro that contains a print specifier.
# AMD can write its own print specifier.
# "AMD_PRINT": "0x%lx"
}
}
}
2 changes: 1 addition & 1 deletion Platform/AMD/AmdPlatformPkg/AmdPlatformPkg.dec
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
gAmdPlatformPkgTokenSpaceGuid.PcdAmdSmbiosType9SlotCharacteristics2.AsyncSurpriseRemoval|0
gAmdPlatformPkgTokenSpaceGuid.PcdAmdSmbiosType9SlotCharacteristics2.FlexbusSlotCxl10Capable|0
gAmdPlatformPkgTokenSpaceGuid.PcdAmdSmbiosType9SlotCharacteristics2.FlexbusSlotCxl20Capable|0
gAmdPlatformPkgTokenSpaceGuid.PcdAmdSmbiosType9SlotCharacteristics2.Reserved|0
gAmdPlatformPkgTokenSpaceGuid.PcdAmdSmbiosType9SlotCharacteristics2.FlexbusSlotCxl30Capable|0

#
# SPI PCDs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ GenerateLocalNmi (

**/
EFI_STATUS
GenerateIntrruptSourceOverride (
GenerateinterruptSourceOverride (
IN OUT EFI_ACPI_6_5_INTERRUPT_SOURCE_OVERRIDE_STRUCTURE **InterruptSourceOverride,
IN OUT UINTN *InterruptSourceOverrideSize
)
Expand Down Expand Up @@ -343,7 +343,7 @@ GenerateProcessorLocalApicStructure (
}
}

/// Increatement the NumSocket and ThreadsPerCore by 1, as it is 0 based
/// increment the NumSocket and ThreadsPerCore by 1, as it is 0 based
NumSocket++;
ThreadsPerCore++;

Expand Down Expand Up @@ -704,7 +704,7 @@ AcpiMadtLibConstructor (
TableSize += IoApicSize;

/// Generate Interrupt Source Override Structure
Status = GenerateIntrruptSourceOverride (&InterruptSourceOverride, &InterruptSourceOverrideSize);
Status = GenerateinterruptSourceOverride (&InterruptSourceOverride, &InterruptSourceOverrideSize);
if (EFI_ERROR (Status)) {
DEBUG ((
DEBUG_ERROR,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ GenerateApicIdToUidMap (
}
}

// Increarement the SocketCount by 1 because socket numbering starts from 0
// increment the SocketCount by 1 because socket numbering starts from 0
SocketCount++;

if (SocketCount > 1) {
Expand Down
Loading
Loading