Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampere: Apply uncrustify/unix2dos changes and enable some features #206

Merged
merged 7 commits into from
Sep 25, 2024

Conversation

nhivp
Copy link
Member

@nhivp nhivp commented Sep 20, 2024

This enables Boot Discovery Policy, EFI Memory Attribute Protocol installation manager, and adds validation of the returned TRNG value from mailbox.

Also, this patchset applies changes from running uncrustify and unix2dos for the Silicon/Ampere and Platform/Ampere folder to comply with EDK2 coding standard.

The Boot Discovery Policy allows users to specify which class of device
shall be connected during a normal UEFI boot by modifying the HII PCD
PcdBootDiscoveryPolicy or configuring in the Boot Maintenance Menu.

By default, the boot discovery policy is minimal which it does not
connect any additional devices.

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
This driver allows users to disable the EFI Memory Attribute protocol
through an HII setup option, in order to work around a broken version of
rhboot's shim used in some distros (e.g. CentOS Stream 9) which
incorrectly invokes the protocol and results in a Synchronous Exception.

Default is enabled.

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
This adds a validation of the TRNG value returned by the Mailbox
interface, according to the new update in SMpro which adds additional
bits for providing the operation status, success (0) or failure (1).

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
This applies uncrustify changes to .c/.h files in the AmpereAltraPkg
package.

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
This applies uncrustify changes to .c/.h files in the AmpereSiliconPkg
package.

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
This applies uncrustify changes to .c/.h files in the JadePkg package.

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
This applies the unix2dos changes for fixing line ending error.

No functional change.

Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
@leiflindholm
Copy link
Member

Please put affected packages in PR title just like you'd do for commit messages.

@nhivp nhivp changed the title Apply uncrustify/unix2dos changes and enable some features Ampere: Apply uncrustify/unix2dos changes and enable some features Sep 24, 2024
Copy link
Contributor

@chuongtranle chuongtranle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this patch series:
Reviewed-by: Chuong Tran chuong@os.amperecomputing.com

@nhivp nhivp merged commit 528298b into tianocore:master Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants