Enable SecureBoot flag build on U540 and bootable on RISCV QEMU #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However, some library included are null libs here, and there's some unsupported function during SecureBootConfigDxe, specifically InvalidateInstructionCacheRange that needs to be fixed Signed-off-by: Loo Tung Lun <joshlootunglun@gmail.com>
| @@ -419,6 +422,7 @@ | |||
| <LibraryClasses> | |||
| NULL|SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.inf | |||
| } | |||
| SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf | |||
There was a problem hiding this comment.
This is already present at Line 531.
But it would probably be nice to get it closer together. I.e. put it here and remove it from below
|
The TianoCore project doesn't use Pull Requests (yet), so you'll need to send the patch to devel@edk2.groups.io (see https://edk2.groups.io) to have it considered for inclusion. |
|
rebase please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables build with -DSECURE_BOOT_ENABLE=TRUE flag.
However, some library included are null libraries here, and during boot,
there's some unsupported function during SecureBootConfigDxe,
specifically InvalidateInstructionCacheRange that needs to be fixed
Signed-off-by: Loo Tung Lun joshlootunglun@gmail.com