Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception for Pr eval when Pr has deleted folders #202

Merged
merged 4 commits into from
Jun 12, 2020
Merged

Fix exception for Pr eval when Pr has deleted folders #202

merged 4 commits into from
Jun 12, 2020

Conversation

spbrogan
Copy link
Member

No description provided.

@spbrogan
catch exception if GetContainingModules raises one because the parent…
d02494b 
… folder was deteled.
@spbrogan
Change exception handling for failed attempt to get containing packag…
2465772 
…e to report as warning instead of error since this is expected for file deletes.
@spbrogan spbrogan added this to the 0.13.7 milestone Jun 12, 2020
@spbrogan spbrogan linked an issue Jun 12, 2020 that may be closed by this pull request
stuart_pr_eval raises exception on a PR where a folder was deleted #201
Closed
@spbrogan spbrogan added the bug Something isn't working label Jun 12, 2020
@spbrogan spbrogan self-assigned this Jun 12, 2020
@codecov
Copy link

codecov bot commented Jun 12, 2020 •
edited
Loading

Codecov Report

Merging #202 into master will increase coverage by 0.92%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   62.84%   63.76%   +0.92%     
==========================================
  Files          37       37              
  Lines        3827     3831       +4     
==========================================
+ Hits         2405     2443      +38     
+ Misses       1422     1388      -34
Flag Coverage Δ
#Linux 62.77% <0.00%> (-0.07%) ⬇️
#Windows_NT 63.69% <0.00%> (?)
Impacted Files Coverage Δ
edk2toolext/invocables/edk2_pr_eval.py 0.00% <0.00%> (ø)
edk2toolext/edk2_invocable.py 60.99% <0.00%> (+0.70%) ⬆️
edk2toolext/environment/repo_resolver.py 70.66% <0.00%> (+2.00%) ⬆️
edk2toolext/capsule/signtool_signer.py 54.32% <0.00%> (+41.97%) ⬆️

@spbrogan spbrogan merged commit 2505a53 into tianocore:master Jun 12, 2020
@spbrogan spbrogan deleted the pr_eval_deleted_folders branch June 12, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewfcarlson matthewfcarlson Awaiting requested review from matthewfcarlson

@mdkinney mdkinney Awaiting requested review from mdkinney

Assignees

@spbrogan spbrogan

Labels
bug Something isn't working
Projects
None yet
Milestone
0.13.7
Development

Successfully merging this pull request may close these issues.

stuart_pr_eval raises exception on a PR where a folder was deleted
1 participant
@spbrogan