coverage_report: Allow package filtering for --by-platform #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apop5
approved these changes
Feb 16, 2024
Originally, both a --by-package and --by-platform flag was created to describe the types of coverage reports able to be generated, and allow for grouping the command line arguments based on these two flags. With the adding of the ability to filter on packages for the platform report, the --by-package flag no longer has any special arguments and can be deprecated. Due to this, this change also removes the --by-package flag, making it the default behavior, which is overridden by --py-platform.
Javagedes
force-pushed
the
coverage-filter-package-on-by-platform
branch
from
df4ad0f
to
44f4eef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
=======================================
Coverage 78.75% 78.75%
=======================================
Files 49 49
Lines 4909 4909
=======================================
Hits 3866 3866
Misses 1043 1043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, both a --by-package and --by-platform flag was created to describe the types of coverage reports able to be generated, and allow for grouping the command line arguments based on these two flags.
With the adding of the ability to filter on packages for the platform report, the --by-package flag no longer has any special arguments and can be deprecated. Due to this, this change also removes the --by-package flag, making it the default behavior, which is overridden by --py-platform.