edk2_invocable: Bugfix for bad argument handling #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a bug in the edk2_invocable.py script where an invalid command line argument would not cause the script to exit with an error. This occured due to a change that enabled non-valued environment variables to be passed to the script. The result of this change was that any invalid command line argument would be added as a non-valued environment variable rather than triggering the error handling. This change is such that any non-valued environment variable can not start with a '-' character, as that is reserved for argparse arguments.
apop5
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug in the edk2_invocable.py script where an invalid command line argument would not cause the script to exit with an error.
This occured due to a change that enabled non-valued environment variables to be passed to the script. The result of this change was that any invalid command line argument would be added as a non-valued environment variable rather than triggering the error handling.
This commit makes it such that any non-valued environment variable cannot start with a '-' character, as that is reserved for argparse arguments.