Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edk2_invocable.py: Improve documentation for SDE related functions #791

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

yangrongwei
Copy link
Contributor

@yangrongwei yangrongwei commented Apr 9, 2024

Improve the documentation for GetActriveScopes and GetSkippedDirectories to specify that these are used by the self_descriving_environment (SDE) to ignore parts of the workspace and to control which custom components (path_env, ext_dep, and plug_in are loaded for a given execution.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (bf643b0) to head (149793a).
Report is 43 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
+ Coverage   78.75%   78.76%   +0.01%     
==========================================
  Files          49       49              
  Lines        4909     4921      +12     
==========================================
+ Hits         3866     3876      +10     
- Misses       1043     1045       +2     
Files Coverage Δ
edk2toolext/edk2_invocable.py 75.54% <ø> (+0.13%) ⬆️

... and 2 files with indirect coverage changes

@Javagedes Javagedes changed the title Refine comment for SDE edk2_invocable.py: Improve documentation for SDE related functions Apr 9, 2024
@Javagedes Javagedes added this to the 0.27.4 milestone Apr 9, 2024
@Javagedes Javagedes added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 9, 2024
@Javagedes Javagedes self-assigned this Apr 9, 2024
@Javagedes Javagedes merged commit 8184bf8 into tianocore:master Apr 9, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants