Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter handling in repo_resolver and update logging configuration. #838

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

joschock
Copy link
Contributor

  • Fix an issue with parameter handling in repo_resolver that prevented "branch", "shallow", and "reference" parameters from being passed to git clone operations.
  • Updated logging configuration to allow better tracing of repo_resolver operations for future debugging of similar issues.

Javagedes and others added 4 commits June 28, 2024 16:01

Verified

This commit was signed with the committer’s verified signature.
Aaronontheweb Aaron Stannard

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…eference from functioning
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (bf643b0) to head (9a91ce1).
Report is 72 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #838      +/-   ##
==========================================
- Coverage   78.75%   78.48%   -0.27%     
==========================================
  Files          49       40       -9     
  Lines        4909     4890      -19     
==========================================
- Hits         3866     3838      -28     
- Misses       1043     1052       +9     
Files Coverage Δ
edk2toolext/edk2_logging.py 88.46% <100.00%> (-0.07%) ⬇️
edk2toolext/environment/repo_resolver.py 92.53% <100.00%> (+2.15%) ⬆️

... and 47 files with indirect coverage changes

@Javagedes Javagedes added the bug Something isn't working label Jul 1, 2024
@Javagedes Javagedes added this to the 0.26.7 milestone Jul 1, 2024
@Javagedes Javagedes merged commit d5c1649 into tianocore:master Jul 1, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants