Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust Environment module #848

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Conversation

makubacki
Copy link
Member

Adds helpers for checking if a firmare environment is ready to build Rust.

The primary purpose of the functionality in rust_environment is to be used in a build plugin wrapper. However, the public functions may be used in other contexts as well.

@makubacki makubacki added the enhancement New feature or request label Jul 11, 2024
@makubacki makubacki requested a review from Javagedes July 11, 2024 23:44
Adds helpers for checking if a firmare environment is ready to build
Rust.

The primary purpose of the functionality in rust_environment is to be
used in a build plugin wrapper. However, the public functions may be
used in other contexts as well.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 86.56716% with 18 lines in your changes missing coverage. Please review.

Project coverage is 78.70%. Comparing base (bf643b0) to head (0f4f29c).
Report is 82 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
- Coverage   78.75%   78.70%   -0.05%     
==========================================
  Files          49       41       -8     
  Lines        4909     5049     +140     
==========================================
+ Hits         3866     3974     +108     
- Misses       1043     1075      +32     
Files Coverage Δ
edk2toolext/environment/rust.py 86.56% <86.56%> (ø)

... and 49 files with indirect coverage changes

Copy link
Contributor

@Javagedes Javagedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing tests.

docs/user/features/rust_environment.md Outdated Show resolved Hide resolved
docs/user/features/rust_environment.md Outdated Show resolved Hide resolved
edk2toolext/rust_environment.py Outdated Show resolved Hide resolved
docs/user/features/rust_environment.md Outdated Show resolved Hide resolved
edk2toolext/rust_environment.py Outdated Show resolved Hide resolved
edk2toolext/rust_environment.py Outdated Show resolved Hide resolved
edk2toolext/rust_environment.py Outdated Show resolved Hide resolved
edk2toolext/rust_environment.py Outdated Show resolved Hide resolved
edk2toolext/rust_environment.py Outdated Show resolved Hide resolved
edk2toolext/rust_environment.py Outdated Show resolved Hide resolved
@Javagedes Javagedes merged commit 99b075b into tianocore:master Jul 12, 2024
24 of 25 checks passed
@Javagedes Javagedes added this to the 0.27.10 milestone Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants