Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdePkg: Fix Clang Build Error #10689

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

sachinami
Copy link
Contributor

@sachinami sachinami commented Jan 28, 2025

Description

Fixed Clang build error introduced by uninitialized variables in 6278bbb

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Integration Instructions

N/A

Fixed Clang build error introduced by unintialized variables in
tianocore@6278bbb

Signed-off-by: Sachin Ganesh <sachinganesh@ami.com>
@sachinami
Copy link
Contributor Author

@ardbiesheuvel Fixed issue introduced in #10617

@ardbiesheuvel ardbiesheuvel added the push Auto push patch series in PR if all checks pass label Jan 28, 2025
@mergify mergify bot merged commit 428cd8a into tianocore:master Jan 28, 2025
127 checks passed
@mdkinney
Copy link
Member

Thanks for the quick fix to this CLANG compatibility issue. I would like to see CLANG added to CI to help catch these types of issues before they are merged.

@ardbiesheuvel
Copy link
Member

Thanks for the quick fix to this CLANG compatibility issue. I would like to see CLANG added to CI to help catch these types of issues before they are merged.

Agreed. We could swap out some GCC5 targets with CLANGDWARF so we don't have to increase the overall CI workload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants