Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShellPkg: add missing linefeed in reset message #6200

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

xypron
Copy link
Contributor

@xypron xypron commented Sep 13, 2024

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4850

When running 'reset -s' no linefeed is printed. This results in the Linux command line prompt not being printed at the start of a new line:

Shell> reset -s
Reset with <null string> (0 bytes)user@workstation:/tmp$

Add the missing linefeed.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4850

When running 'reset -s' no linefeed is printed. This results in the Linux
command line prompt not being printed at the start of a new line:

    Shell> reset -s
    Reset with <null string> (0 bytes)user@workstation:/tmp$

Add the missing linefeed.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
@pierregondois
Copy link
Contributor

Personally I get
Reset with <null string> (0 bytes)DXE ResetSystem2: ResetType Shutdown, Call Depth = 1.
Effectively it doesn't harm to have a new line FWIW

@mdkinney mdkinney added the push Auto push patch series in PR if all checks pass label Sep 24, 2024
@mergify mergify bot merged commit b8122cc into tianocore:master Sep 24, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants