feat: implement thinking configuration resolution and variant mapping#39
Closed
kfiramar wants to merge 1 commit intotickernelz:masterfrom
Closed
feat: implement thinking configuration resolution and variant mapping#39kfiramar wants to merge 1 commit intotickernelz:masterfrom
kfiramar wants to merge 1 commit intotickernelz:masterfrom
Conversation
- Implement low/medium/high/max variants mapping to token budgets - Add support for explicit thinkingConfig budget overrides - Include unit tests for thinking configuration resolution Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Owner
|
i dont know what you're trying to achive in your PRs bro. i see alot of unneeded changes. some of your PRs dont actually fix anything. i think you're creating all your PR all by AI. im sorry but i dont see the critical fixes in all your PRs. im closing it all |
Contributor
Author
|
Asking what I'm trying to achieve in each PR is one question, closing PRs that fix broken code without any note (after you asked for it) is something else... About AI, yeah - surprisingly I did use AI for help (shocker), mostly to break down the PRs you asked About it being broken, you're free to look at opencode Kiro PRs, discussing this project and that it does not work You've lost a maintainer, Good luck! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the thinking configuration resolution logic, enabling the extraction of thinking budgets and variant mappings for model requests. It ensures that token budgets are correctly resolved based on model suffixes, explicit configurations, or variant presets.
Key Features
resolveThinkingConfigto handle logic for enabling thinking and determining token budgets.low,medium,high, andmaxvariants to their respective token budgets (8k, 16k, 32k).maxas an alias for thehighvariant.thinkingBudgetoverrides withinproviderOptions.thinkingConfig.Testing
test/thinking.test.jscovering:-thinking).maxvariant.