Skip to content

Comments

feat: implement thinking configuration resolution and variant mapping#39

Closed
kfiramar wants to merge 1 commit intotickernelz:masterfrom
kfiramar:feat/thinking-blocks
Closed

feat: implement thinking configuration resolution and variant mapping#39
kfiramar wants to merge 1 commit intotickernelz:masterfrom
kfiramar:feat/thinking-blocks

Conversation

@kfiramar
Copy link
Contributor

@kfiramar kfiramar commented Feb 3, 2026

Summary

This PR implements the thinking configuration resolution logic, enabling the extraction of thinking budgets and variant mappings for model requests. It ensures that token budgets are correctly resolved based on model suffixes, explicit configurations, or variant presets.

Key Features

  • Thinking Configuration Resolution: Added resolveThinkingConfig to handle logic for enabling thinking and determining token budgets.
  • Variant Mapping: Implemented mapping for low, medium, high, and max variants to their respective token budgets (8k, 16k, 32k).
  • Backward Compatibility: Supports max as an alias for the high variant.
  • Explicit Overrides: Supports explicit thinkingBudget overrides within providerOptions.thinkingConfig.

Testing

  • Added comprehensive unit tests in test/thinking.test.js covering:
    • Model suffix detection (-thinking).
    • Explicit budget overrides.
    • Variant-to-budget mapping.
    • Backward compatibility for the max variant.

- Implement low/medium/high/max variants mapping to token budgets
- Add support for explicit thinkingConfig budget overrides
- Include unit tests for thinking configuration resolution

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
@kfiramar kfiramar changed the title feat(request): add missing thinking block extraction and tests feat: implement thinking configuration resolution and variant mapping Feb 3, 2026
@tickernelz
Copy link
Owner

i dont know what you're trying to achive in your PRs bro. i see alot of unneeded changes. some of your PRs dont actually fix anything. i think you're creating all your PR all by AI. im sorry but i dont see the critical fixes in all your PRs. im closing it all

@kfiramar
Copy link
Contributor Author

kfiramar commented Feb 4, 2026

Asking what I'm trying to achieve in each PR is one question, closing PRs that fix broken code without any note (after you asked for it) is something else... About AI, yeah - surprisingly I did use AI for help (shocker), mostly to break down the PRs you asked

About it being broken, you're free to look at opencode Kiro PRs, discussing this project and that it does not work

You've lost a maintainer, Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants