Use better show instances for notes & rationals #857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the discussion from #807 it came up that the
Show
instance for notes is a bit confusing, because it exposes the structure of the Note type. I added a new show function that prints the numeric value followed by the note name. Here's what it looks like in the context of a pattern:I also updated the
Show
instance for patterns to use the prettier rational representation (used by time spans) for rational values.