Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: support international alphabets in sample names #750

Closed
ilesinge opened this issue Oct 21, 2023 · 3 comments
Closed

idea: support international alphabets in sample names #750

ilesinge opened this issue Oct 21, 2023 · 3 comments

Comments

@ilesinge
Copy link
Contributor

ilesinge commented Oct 21, 2023

As a non-English natively speaking user, I would like to have sample names in my mother tongue (especially spoken words).

Currently, only alpha-numeric characters are allowed in the parser.

This would be particularly interesting in combination with the speak function and with shabda's speech mode, which both do direct step name to voice generation and thus cannot be used currently with some non-English languages in mininotation.

Looking at this pegjs issue and after experimenting that the Unicode Character Categories such as \p{Letter} are not supported in pegjs, it would seem that the most obvious, if not elegant, solution, would be to add all alphabets in the parser such as in the example JavaScript parser.

@felixroos
Copy link
Collaborator

yep i'd also love to use german special chars sometimes + using emojis would be cool too

@ilesinge ilesinge changed the title idea: support international alphabets in mininotation idea: support international alphabets in sample names Oct 21, 2023
@ilesinge
Copy link
Contributor Author

The pull request adds german special chars (but excludes emojis), if you want to have a look (not super satisfied about it but I go around pegjs limitations)

@felixroos
Copy link
Collaborator

fixed in #751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants