-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mini notation: international alphabets support #751
Conversation
looks like there are ways to customize the peggy error message: https://peggyjs.org/documentation.html#error-messages maybe it is customizable enough to allow not printing all these characters and just write something like "character x cannot be used" |
Having a look at the error message customization, thanks :) |
one potential danger i see here is that some of these chars might become useful later to be used as new operators in mini notation. so it will become a breaking change if new characters are needed that are part of this set. many programming languages reserve a bunch of words that might become language features later, even if they are never used in the end. |
ah perfect |
Regarding potential operator characters, it should be noted that the added characters do not include special characters, only letters that are not "universally" easily typeable since they are in other alphabets or include diacritics. |
good point! so maybe we don't need to reserve any of those then
i think we can keep it as is then |
maybe remove the 180 limit again then? More then 180 could be useful in some scenarios as some js errors are really long and might contain useful info at the end |
✔️ Removed the 180 limit |
looks good, I think this is ready to merge then! @yaxu this is pretty core / potentially tied to tidal compat so I'll ping you to ask if you have any objections? |
Fine by me! |
Thanks! |
Implements #750
Note that without reducing the max error message's length to 180 in the Repl (while keeping the end of the error message), the screen becomes unusable when one use a character that is not included (such as "$"). The full error message can still be found in the console as seen below.
It could be possible to do the same length reduction with the error in the console.