Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch 'operators' from .whatHow to .what.how #285

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Conversation

yaxu
Copy link
Member

@yaxu yaxu commented Dec 7, 2022

Makes sure there are toplevel curried functions for all of them.
Renames util.mod to util._mod, to make room for toplevel 'operator' of that name.

…e toplevel curried functions for all of them. Rename util.mod to util._mod, to make room for toplevel 'operator' of that name.
Copy link
Collaborator

@felixroos felixroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! maybe we can rename _mod to modulo at some point

@yaxu
Copy link
Member Author

yaxu commented Dec 7, 2022

looks good! maybe we can rename _mod to modulo at some point

I did! But then changed it to this, as there's a convention for non patterny functions to have the underscore.. but no strong opinion

@yaxu yaxu merged commit f827201 into main Dec 7, 2022
@yaxu yaxu deleted the out-of-the-op-matrix branch December 7, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants