Vanilla JS Refactoring #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ pianoroll now uses .onPaint
+ use it in vite-vanilla-repl-cm6
... from vite-vanilla-repl-cm6
+ move repl + drawer boilerplate inside StrudelMirror
for some reason they were missing after update + darken line backgrounds + change preview port to keep workbox out of dev server
|
finally merging this now.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement some things in vanilla js that were previously only in react land:
Drawerto schedule drawing haps in past present and future, similar tousePatternFramehook@strudel/codemirrorpackage that usesDrawer+ repl as part of newStrudelMirrorinterface@strudel/webpackage that simplifies using strudel as a libraryTODO:
in a future PR, the react package can also be refactored to use
Drawer(and maybe codemirror package?) (#564)I am also thinking about reimplementing the main repl in SolidJS :P
also check out this sandbox