Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydra fixes and improvements #818

Merged
merged 13 commits into from
Nov 25, 2023
Merged

Hydra fixes and improvements #818

merged 13 commits into from
Nov 25, 2023

Conversation

atfornes
Copy link
Contributor

Fixing hydra integration:

  • Improve performace
  • Enable hydra audio detection
  • Add example using hydra audio detection in documentation

@felixroos
Copy link
Collaborator

felixroos commented Nov 24, 2023

thank you :)
I've tried my best to merge main into this one, where #808 was merged earlier.
I've also changed the canvas from absolute to fixed, so scrolling wont move the canvas.
I am curious why this fix works / why there were performance problems earlier, was it the way the canvas was initialized or was it because of s0.init({ src: testCanvas }) ?

@atfornes
Copy link
Contributor Author

Thanks, the code is cleaner now :)

I think the performance issue was mainly due to the cloning of testCanvas: const hydraCanvas = testCanvas.cloneNode(true);

@felixroos
Copy link
Collaborator

Thanks, the code is cleaner now :)

I think the performance issue was mainly due to the cloning of testCanvas: const hydraCanvas = testCanvas.cloneNode(true);

ok good to know!

I've now also added a feedStrudel option to initHydra that will send the strudel canvas to s0:

Bildschirmfoto 2023-11-24 um 12 51 51

this is super fun to use, works with pianoroll, spiral and scope

@felixroos felixroos merged commit 54b5d69 into tidalcycles:main Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants