Date progress: add timeinterval to progress bar #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can set custom start/stop times for day progress bar percentage. values can be over 100%.
rs7q5
requested review from
betterengineering,
rohansingh and
matslina
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@possan I have added the feature request I requested, so this PR Fixes #186. I think I have addressed both intervals for the day progress bar if it does it over midnight, but let me know if I didn't. The bars can be calculated over 100% now too, so the thick red line will go off screen, which I don't personally see as an issue.
To prevent breakage in case there is a bug, a user explicitly needs to enable the custom day progress interval though, so the original usage still works.
Let me know if my math is off though.
edit: clarification in the first sentence
edit2: a solution to #143 would be helpful here.