Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steam Top Sellers - Improved game art animation and details marquee formatting. #2904

Conversation

johnkalbac
Copy link
Contributor

Some minor improvements for the Steam Top Sellers app:

  • Randomized game art animations and increased the display duration
  • Flipped order of frames so game art appears before text details
  • Updated the marquee text padding so shorter game titles repeat
  • Updated the filter for Steam Deck entries (since they are not especially helpful in this app)

steam_top_sellers

@johnkalbac johnkalbac requested a review from matslina as a code owner December 14, 2024 15:31
@tidbyt
Copy link

tidbyt bot commented Dec 14, 2024

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of animation.star requires review
Original Author The original author matches the PR author

@stale stale bot added the wontfix label Jan 14, 2025
Copy link

stale bot commented Jan 15, 2025

We're automatically closing this issue because it hasn't had any activity in 30 days. If that seems like a mistake, please feel free to re-open. Thanks!

@tavdog
Copy link
Contributor

tavdog commented Jan 16, 2025

Feel free to submit your PR to my hard fork of community here https://github.com/tavdog/tronbyt-apps

@tidbyt tidbyt locked as resolved and limited conversation to collaborators Jan 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants