fix: can't open git app on windows

#572

package.json

@@ -120,7 +120,7 @@
  "@types/styled-components": "5.1.34",
  "@types/webpack-bundle-analyzer": "4.7.0",
  "@types/webpack-node-externals": "3.0.4",
- "@vercel/webpack-asset-relocator-loader": "1.7.4",
+ "@vercel/webpack-asset-relocator-loader": "1.7.3",
  "beautiful-react-hooks": "5.0.2",
  "chai": "5.1.1",
  "circular-dependency-plugin": "5.2.2",

src/services/native/externalApp/launch.ts

@@ -27,7 +27,7 @@ export async function launchExternalEditor(fullPath: string, editor: FoundEditor
  detached: true,
  };
 
- if (editor.usesShell) {
+ if (editor.usesShell === true) {
  spawn(`"${editorPath}"`, [`"${fullPath}"`], { ...options, shell: true });
  } else if (isMac) {
  // In macOS we can use `open`, which will open the right executable file

src/services/native/externalApp/win32.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/strict-boolean-expressions */
 /* eslint-disable unicorn/import-style */
 import * as Path from 'path';
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment, @typescript-eslint/prefer-ts-expect-error
@@ -94,8 +95,7 @@ const registryKeysForJetBrainsIDE = (product: string): readonly RegistryKey[] =>
  if (minorRelease > 0) {
  key = `${key}.${minorRelease}`;
  }
- result.push(Wow64LocalMachineUninstallKey(key));
- result.push(CurrentUserUninstallKey(key));
+ result.push(Wow64LocalMachineUninstallKey(key), CurrentUserUninstallKey(key));
  }
  }
  }
@@ -389,7 +389,7 @@ export async function getAvailableEditors(editorName?: string): Promise<Readonly
  results.push({
  editor: editor.name,
  path,
- usesShell: path.endsWith('.cmd'),
+ usesShell: path.endsWith('.cmd') || path.endsWith('.bat'),
  });
  }
  }
@@ -411,7 +411,7 @@ export async function getAvailableGitGUIApps(): Promise<ReadonlyArray<IFoundEdit
  results.push({
  editor: guiApp.name,
  path,
- usesShell: path.endsWith('.cmd'),
+ usesShell: path.endsWith('.cmd') || path.endsWith('.bat'),
  });
  }
  }