fix: remove msi builder, to fix node-gyp failed to rebuild @bitdisast…

…er/exe-icon-extractor

.github/workflows/release.yml

@@ -215,8 +215,8 @@ jobs:
  - name: Install dependencies
  run: pnpm install --no-frozen-lockfile
 
- - name: Add msi to path
- run: echo "${env:wix}bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
+ # - name: Add msi to path
+ #  run: echo "${env:wix}bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
  # Enable x32 if someone still need it
  # - name: Make Windows (ia32)
  # run: pnpm run make:win-ia32
@@ -238,10 +238,10 @@ jobs:
  CI: true
  CI_PULL_REQUEST: ${{ github.event_name == 'pull_request' }}
  GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- - name: Rename (x64)
- run: |
- Get-ChildItem out/make/wix/x64
- Rename-Item -Path "out/make/wix/x64/TidGi.msi" -NewName "Install-TidGi-Windows-x64.msi"
+ # - name: Rename (x64)
+ #  run: |
+ #  Get-ChildItem out/make/wix/x64
+ #  Rename-Item -Path "out/make/wix/x64/TidGi.msi" -NewName "Install-TidGi-Windows-x64.msi"
  - name: Make Windows (arm64)
  run: pnpm run make:win-arm
  env:
@@ -250,20 +250,20 @@ jobs:
  CI: true
  CI_PULL_REQUEST: ${{ github.event_name == 'pull_request' }}
  GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- - name: Rename (arm64)
- run: |
- Get-ChildItem out/make/wix/arm64
- Rename-Item -Path "out/make/wix/arm64/TidGi.msi" -NewName "Install-TidGi-Windows-arm64.msi"
+ # - name: Rename (arm64)
+ #  run: |
+ #  Get-ChildItem out/make/wix/arm64
+ #  Rename-Item -Path "out/make/wix/arm64/TidGi.msi" -NewName "Install-TidGi-Windows-arm64.msi"
 
  - name: Create Release
  uses: softprops/action-gh-release@v1
  if: startsWith(github.ref, 'refs/tags/')
  with:
  draft: true
  generate_release_notes: true
+ # out/make/**/*.msi
  files: |
  out/make/**/*.exe
- out/make/**/*.msi
  env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 

forge.config.js

@@ -46,27 +46,28 @@ const config = {
  };
  },
  },
- {
- name: '@electron-forge/maker-wix',
- config: (arch) => {
- return {
- language: 1033,
- manufacturer: 'tiddlywiki.org',
- programFilesFolderName: 'TiddlyWiki',
- shortcutFolderName: 'TiddlyWiki',
- description,
- exe: 'TidGi',
- name: 'TidGi',
- ui: {
- chooseDirectory: true,
- },
- appIconPath: 'build-resources/icon.ico',
- // WiX distributables do not handle prerelease information in the app version, removing it from the MSI (-prerelease3.4)
- // and https://github.com/felixrieseberg/electron-wix-msi/issues/110 ask use to use fixed number
- version: '1.0.0',
- };
- },
- },
+ // ✖ Preparing native dependencies: 0 / 1 [FAILED: node-gyp failed to rebuild '/Users/runner/work/TidGi-Desktop/TidGi-Desktop/node_modules/.pnpm/@bitdisaster+exe-icon-extractor@1.0.10/node_modules/@bitdisaster/exe-icon-extractor']
+ // {
+ // name: '@electron-forge/maker-wix',
+ // config: (arch) => {
+ // return {
+ // language: 1033,
+ // manufacturer: 'tiddlywiki.org',
+ // programFilesFolderName: 'TiddlyWiki',
+ // shortcutFolderName: 'TiddlyWiki',
+ // description,
+ // exe: 'TidGi',
+ // name: 'TidGi',
+ // ui: {
+ // chooseDirectory: true,
+ // },
+ // appIconPath: 'build-resources/icon.ico',
+ // // WiX distributables do not handle prerelease information in the app version, removing it from the MSI (-prerelease3.4)
+ // // and https://github.com/felixrieseberg/electron-wix-msi/issues/110 ask use to use fixed number
+ // version: '1.0.0',
+ // };
+ // },
+ // },
  {
  name: '@electron-forge/maker-zip',
  platforms: ['darwin'],

package.json

@@ -83,8 +83,6 @@
  "@electron-forge/maker-rpm": "7.4.0",
  "@electron-forge/maker-snap": "7.4.0",
  "@electron-forge/maker-squirrel": "7.4.0",
- "@electron-forge/maker-wix": "7.4.0",
- "electron-wix-msi": "^5.1.3",
  "@electron-forge/maker-zip": "7.4.0",
  "registry-js": "1.16.0"
  },