Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAL-818] allow direction of when a plugin is a dependency #623

Merged
merged 4 commits into from
Oct 30, 2024
Merged

[PAL-818] allow direction of when a plugin is a dependency #623

merged 4 commits into from
Oct 30, 2024

Conversation

nhamming
Copy link

@nhamming nhamming requested review from ps2 and Camji55 October 30, 2024 09:23
@nhamming nhamming force-pushed the nate/PAL-818/deleting-service branch from 0e9eac4 to 11adbf3 Compare October 30, 2024 09:24
@nhamming nhamming force-pushed the nate/PAL-818/deleting-service branch from 11adbf3 to 7a87f8b Compare October 30, 2024 12:19
ps2
ps2 approved these changes Oct 30, 2024
View reviewed changes
Copy link

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ps2 ps2 self-requested a review October 30, 2024 15:21
ps2
ps2 requested changes Oct 30, 2024
View reviewed changes
Copy link

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A method name with a prefix of is isDependency is usually a getter to ask a question. This appears to be a setter, so maybe setDependency, or markAsDepedency?

@nhamming nhamming requested a review from ps2 October 30, 2024 17:52
ps2
ps2 approved these changes Oct 30, 2024
View reviewed changes
Copy link

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nhamming nhamming requested a review from ps2 October 30, 2024 18:30
This was referenced Oct 30, 2024
Merged
Merged
ps2
ps2 approved these changes Oct 30, 2024
View reviewed changes
Copy link

@ps2 ps2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This was referenced Oct 30, 2024
Merged
Merged
Merged
Merged
@nhamming nhamming merged commit d625510 into dev Oct 30, 2024
1 check passed
@nhamming nhamming deleted the nate/PAL-818/deleting-service branch October 30, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps2 ps2 ps2 approved these changes

@Camji55 Camji55 Awaiting requested review from Camji55

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhamming @ps2