-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BACK-2540] Reports api #77
base: master
Are you sure you want to change the base?
Conversation
formatting updates for consistency
allow daterange per report
type: string | ||
description: The medical record number of the patient | ||
minLength: 1 | ||
$ref: ../../metadata/models/mrn.v1.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making changes to clinic service models is undesirable, because the clinic and server stubs are generated from this spec. I have previously found the deep references are not well supported by the code generator and cause issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all done @toddkazakov - I have removed that update
Single user report API request (assuming we include multiple users reports later) This is from the working example that @krystophv and I have worked on in the export service to be accessed by blip also
Implementation tidepool-org/export#43
also included: