Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACK-2540] Reports api #77

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

[BACK-2540] Reports api #77

wants to merge 21 commits into from

Conversation

jh-bate
Copy link
Contributor

@jh-bate jh-bate commented May 30, 2023

Single user report API request (assuming we include multiple users reports later) This is from the working example that @krystophv and I have worked on in the export service to be accessed by blip also

Implementation tidepool-org/export#43

also included:

@jh-bate jh-bate marked this pull request as ready for review June 20, 2023 02:34
@jh-bate jh-bate removed the request for review from clintonium-119 July 6, 2023 05:23
@jh-bate jh-bate changed the title Reports api [BACK-2540] Reports api Jul 6, 2023
@jh-bate jh-bate requested a review from krystophv July 6, 2023 10:40
type: string
description: The medical record number of the patient
minLength: 1
$ref: ../../metadata/models/mrn.v1.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making changes to clinic service models is undesirable, because the clinic and server stubs are generated from this spec. I have previously found the deep references are not well supported by the code generator and cause issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all done @toddkazakov - I have removed that update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants