[LOOP-5035] report time zone changes #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhamming
force-pushed
the
nate/feature/LOOP-5035/report-time-zone-changes
branch
from
f576f31 to
7cd048e
Compare
nhamming
commented
Sep 18, 2024
| @@ -485,6 +486,33 @@ extension TidepoolService: RemoteDataService { | |||
|
|
|||
| return (created, updated, lastControllerSettingsDatum, lastCGMSettingsDatum, lastPumpSettingsDatum) | |||
| } | |||
|
|
|||
| private func uploadTimeZoneChangeData(from fromTimeZone: TimeZone, to toTimeZone: TimeZone, method: TTimeChangeDeviceEventDatum.Method = .automatic, at date: Date = Date()) async throws { | |||
There was a problem hiding this comment.
the method defaults to .automatic, but truly the method is not included in the notification and thus is unknown. Does this matter?
There was a problem hiding this comment.
I think it will still accomplish it's main goal of letting data science track which timezone the user is in.
nhamming
force-pushed
the
nate/feature/LOOP-5035/report-time-zone-changes
branch
from
b2b34e5 to
f43252f
Compare
ps2
approved these changes
Sep 18, 2024
| @@ -19,7 +19,7 @@ actor DeviceLogUploader { | |||
|
|
|||
| private var delegate: RemoteDataServiceDelegate? | |||
|
|
|||
| private var logChunkDuration = TimeInterval(hours: 1) | |||
| private var logChunkDuration = TimeInterval(minutes: 5)//TimeInterval(hours: 1) | |||
| @@ -485,6 +486,33 @@ extension TidepoolService: RemoteDataService { | |||
|
|
|||
| return (created, updated, lastControllerSettingsDatum, lastCGMSettingsDatum, lastPumpSettingsDatum) | |||
| } | |||
|
|
|||
| private func uploadTimeZoneChangeData(from fromTimeZone: TimeZone, to toTimeZone: TimeZone, method: TTimeChangeDeviceEventDatum.Method = .automatic, at date: Date = Date()) async throws { | |||
There was a problem hiding this comment.
I think it will still accomplish it's main goal of letting data science track which timezone the user is in.
nhamming
deleted the
nate/feature/LOOP-5035/report-time-zone-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tidepool.atlassian.net/browse/LOOP-5035