LOOP-1486: add suspend threshold information screen + editor #14
Conversation
| @@ -45,65 +45,20 @@ public struct MockPrescription: Codable { | |||
| public let cgm: CGMType // CGM type (manufacturer & model) | |||
| public let pump: PumpType // Pump type (manufacturer & model) | |||
| public let bloodGlucoseUnit: BGUnit | |||
| public let basalRateSchedule: BasalRateSchedule | |||
There was a problem hiding this comment.
These changes are to make TherapySettings be a subcomponent of a prescription
| } | ||
| let view = SuspendThresholdInformationView(onExit: exiting) | ||
| let hostedView = DismissibleHostingController(rootView: view) | ||
| hostedView.navigationItem.largeTitleDisplayMode = .always // TODO: hack to fix jumping, will be removed once editors have titles |
There was a problem hiding this comment.
Curious if this blocks the scrolls of the title up into the navigation bar?
There was a problem hiding this comment.
The .never would do that if there was an actual title in the settings editor screens, but the settings editors' titles are actually empty strings, so they appear the same
| guard let prescription = viewModel.prescription else { | ||
| // Go back to code entry step if we don't have prescription | ||
| let view = PrescriptionCodeEntryView(viewModel: viewModel) | ||
| return DismissibleHostingController(rootView: view) | ||
| } |
There was a problem hiding this comment.
This is curious to me. Is this a possible entry point of the workflow or can the user just jump to this point? Just trying to understand how the user can get here without the needed information, which then bumps them to the start of the workflow.
There was a problem hiding this comment.
The user shouldn't be able to get here without a prescription; this is primarily to unwrap it (since it's an optional in the view model) and to catch anything weird that could have happened with the Tidepool backend.
https://tidepool.atlassian.net/browse/LOOP-1486
This PR also makes
TherapySettingsbe a subcomponent of aMockPrescription