Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

care partner alerts APNs configuration #296

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ewollesen
Copy link
Contributor

No description provided.

It includes kafka channels that are watched for messages to trigger evaluation
of alerts criteria used to then send push notifications to mobile devices.

BACK-2554
The options key isn't permitted to be a null object, so only include it at all
if shadowing is enabled.
configmap:
enabled: true
data_:
pusherAPNSKeyID: "QA3495JW4S"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pusherAPNSKeyID: "QA3495JW4S"
PusherAPNSKeyID: "QA3495JW4S"

enabled: true
data_:
pusherAPNSKeyID: "QA3495JW4S"
pusherAPNSTeamID: "75U4X84TEG"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pusherAPNSTeamID: "75U4X84TEG"
PusherAPNSTeamID: "75U4X84TEG"

data_:
pusherAPNSKeyID: "QA3495JW4S"
pusherAPNSTeamID: "75U4X84TEG"
pusherAPNSBundleID: "org.tidepool.carepartner"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pusherAPNSBundleID: "org.tidepool.carepartner"
PusherAPNSBundleID: "org.tidepool.carepartner"

valueFrom:
configMapKeyRef:
name: data
key: pusherAPNSBundleID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
key: pusherAPNSBundleID
key: PusherAPNSBundleID

valueFrom:
configMapKeyRef:
name: data
key: pusherAPNSTeamID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
key: pusherAPNSTeamID
key: PusherAPNSTeamID

valueFrom:
secretKeyRef:
name: data
key: pusherAPNSSigningKey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
key: pusherAPNSSigningKey
key: PusherAPNSSigningKey

# If you're running locally via the development cluster, you'll need to
# base64-encode the contents of that file, and add the resulting data to the
# secret. You'll also need to enable the secret in local/Tiltconfig.yaml.
pusherAPNSSigningKey: {{ .Values.secret.data_.pusherAPNSSigningKey | default "" | quote }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pusherAPNSSigningKey: {{ .Values.secret.data_.pusherAPNSSigningKey | default "" | quote }}
PusherAPNSSigningKey: {{ .Values.secret.data_.Pusher.APNS.SigningKey | default "" | quote }}

{{ include "charts.labels.standard" . }}
{{ with .Values.configmap.data_ }}
data:
pusherAPNSKeyID: {{ .pusherAPNSKeyID | default "" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pusherAPNSKeyID: {{ .pusherAPNSKeyID | default "" }}
pusherAPNSKeyID: {{ .PusherAPNSKeyID | default "" }}

{{ with .Values.configmap.data_ }}
data:
pusherAPNSKeyID: {{ .pusherAPNSKeyID | default "" }}
pusherAPNSTeamID: {{ .pusherAPNSTeamID | default "" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pusherAPNSTeamID: {{ .pusherAPNSTeamID | default "" }}
PusherAPNSTeamID: {{ .pusherAPNSTeamID | default "" }}

data:
pusherAPNSKeyID: {{ .pusherAPNSKeyID | default "" }}
pusherAPNSTeamID: {{ .pusherAPNSTeamID | default "" }}
pusherAPNSBundleID: {{ .pusherAPNSBundleID | default "" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pusherAPNSBundleID: {{ .pusherAPNSBundleID | default "" }}
PusherAPNSBundleID: {{ .pusherAPNSBundleID | default "" }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants