adds a Kafka message consumer using the Sarama library #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewollesen
force-pushed
the
eric-asyncevents
branch
2 times, most recently
from
f988828 to
5e91cd5
Compare
ewollesen
force-pushed
the
eric-asyncevents
branch
from
5e91cd5 to
cf1ea9f
Compare
ewollesen
force-pushed
the
eric-asyncevents
branch
from
cf1ea9f to
70d1d02
Compare
ewollesen
commented
Jul 11, 2024
events/config.go
Outdated
| KafkaUsername string `envconfig:"KAFKA_USERNAME" required:"false"` | ||
| KafkaPassword string `envconfig:"KAFKA_PASSWORD" required:"false"` | ||
| KafkaAlertsConfigTopics []string `envconfig:"KAFKA_ALERTS_CONFIG_TOPICS" default:"alerts"` | ||
| KafkaAlertsDataTopics []string `envconfig:"KAFKA_DATA_ALERTS_TOPICS" default:"data.alerts"` |
There was a problem hiding this comment.
I feel like KafkaAlerts(Config|Data)Topics shouldn't be here, but rather in platform..?
I was following the pattern that was already here (see KafkaTopic).
There was a problem hiding this comment.
Having kafka topic in the config was a mistake because you can have multiple topics per service. We need to be able to specify topic prefix/suffix for operational reasons - e.g. moving processing to a different topic.
There was a problem hiding this comment.
Heh, apparently I knew that at some level, as I wan't using these values... I'll just go ahead and remove them.
These are a handful of data structures and behaviors that can be combined to provide flexible processing of Kafka messages. SaramaMessageConsumer is tightly focused on the consumption of Kafka messages. **This is the interface that other packages will want to implement in order to process Kafka messages.** Being a simple interface, it can easily be extended to provide additional behavior, such as retries. One such example is implemented, the NTimesRetryingConsumer. SaramaConsumerGroupHandler implements sarama.ConsumerGroupHandler. The handler is controlled by the consumer group, and is responsible for managing the lifecycle of a SaramaMessageConsumer. It can be extended if the need for more lifecycle support is required. The SaramaEventsConsumer combines a SaramaMessageConsumer and a SaramaConsumerGroupHandler providing them with a simple lifecycle API (the Run() method). This allows other systems (namely platform) to use a very thin adapter layer to control the lifecycle of the consumer. BACK-2554
ewollesen
force-pushed
the
eric-asyncevents
branch
from
70d1d02 to
e6945d3
Compare
Have the basics there, but need to: + write tests + test it + manage consumers for the other topics, whether here or somewhere else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a handful of data structures and behaviors that can be combined to provide flexible processing of Kafka messages.
SaramaMessageConsumer is tightly focused on the consumption of Kafka messages. This is the interface that other packages will want to implement in order to process Kafka messages. Being a simple interface, it can easily be extended to provide additional behavior, such as retries. One such example is implemented, the NTimesRetryingConsumer.
SaramaConsumerGroupHandler implements sarama.ConsumerGroupHandler. The handler is controlled by the consumer group, and is responsible for managing the lifecycle of a SaramaMessageConsumer. It can be extended if the need for more lifecycle support is required.
The SaramaEventsConsumer combines a SaramaMessageConsumer and a SaramaConsumerGroupHandler providing them with a simple lifecycle API (the Run() method). This allows other systems (namely platform) to use a very thin adapter layer to control the lifecycle of the consumer.
BACK-2554