[BACK-43] jellyfish updates based on reuse of legacy _id for migration #203
Conversation
jh-bate
changed the title
|
/deploy qa3 |
|
jh-bate updated values.yaml file in qa3 |
|
jh-bate updated flux policies file in qa3 |
|
jh-bate deployed jellyfish add-dedup-hash branch to qa3 namespace |
|
/deploy qa3 |
|
jh-bate updated values.yaml file in qa3 |
|
jh-bate updated flux policies file in qa3 |
|
jh-bate deployed jellyfish add-dedup-hash branch to qa3 namespace |
|
/deploy qa3 |
|
jh-bate updated values.yaml file in qa3 |
|
jh-bate updated flux policies file in qa3 |
|
jh-bate deployed jellyfish add-dedup-hash branch to qa3 namespace |
|
/deploy qa3 |
|
jh-bate updated values.yaml file in qa3 |
|
jh-bate updated flux policies file in qa3 |
|
jh-bate deployed jellyfish add-dedup-hash branch to qa3 namespace |
|
/deploy qa3 |
|
jh-bate updated values.yaml file in qa3 |
|
jh-bate updated flux policies file in qa3 |
|
jh-bate deployed jellyfish add-dedup-hash branch to qa3 namespace |
There was a problem hiding this comment.
LGTM. One comment on a bit of simplification, if you so choose.
Also, there are a number of outstanding vulnerabilities (npm audit, snyk, dependabot). I ran my usual update process and created a new PR on top of this one. You can either merge into this PR or cherry pick it. The PR is #205.
lib/schema/qa3_user_ids.json
Outdated
| @@ -0,0 +1 @@ | |||
| [] | |||
There was a problem hiding this comment.
You might as well go ahead and check in similar files for all the environments. That way if this is deployed anywhere it will still function, but effectively act the same and use Jellyfish.
* userid hash for platform users
| var schema = require('./schema.js'); | ||
| var misc = require('../misc.js'); | ||
|
|
||
| function usePlatform(userId) { |
There was a problem hiding this comment.
Is this going to reload the user ids from the file every time the info API is called? If so, consider loading the hashed user id array once upon initialization and then simply checking against that pre-loaded hashed user id array.
| exports.loadHashedPlatformUserId = function (env) { | ||
| const filePaths = userIdsPath(env); | ||
| if (!fs.existsSync(filePaths.hashedPath)) { | ||
| throw new Error(`Missing required file ${filePaths.hashedPath}`); |
There was a problem hiding this comment.
Since this is going to fail if the hashed path for the environment doesn't exist, do we need to commit empty files (well, files with just []) for every environment with this PR?
|
/deploy qa3 |
|
jh-bate updated values.yaml file in qa3 |
|
jh-bate updated flux policies file in qa3 |
|
jh-bate deployed jellyfish add-dedup-hash branch to qa3 namespace |
|
/deploy qa3 |
|
jh-bate updated values.yaml file in qa3 |
|
jh-bate updated flux policies file in qa3 |
|
jh-bate deployed jellyfish add-dedup-hash branch to qa3 namespace |
see tidepool-org/development#297