add evaluation of not looping alerts #751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Get endpoint already exists on the service, so only the List endpoint needed to be added there. BACK-2554
Through discussions it was confirmed that Repeat is not universal to all alerts. So it's lifted out of the Base alert and re-inserted into those alerts where it should be present (namely Low and High alerts only). BACK-2554
These activity properties will track the times at which alerts were sent, resolved, or acknowledged. BACK-2554
This endpoint will be used by upcoming changes to the auth client to allow care partner backend processes to retrieve device tokens in order to send mobile device push notifications. BACK-2554
This functionality will be used by care partner processes to retrieve device tokens in order to send mobile device push notifications in response to care partner alerts being triggered. BACK-2554
This was missed when moving device tokens from the data service to the auth service in commit a0f5a84. BACK-2554
Basic steps are taken to allow for other push notification services to be easily added in the future. BACK-2554
So that sarama log messages better follow our standards, and will be emitted as JSON when log.Logger is configured for that. Before this change, the sarama logs were printed in plain-text without any of the benefits of the platform log.Logger. BACK-2554
The existing FaultTolerantConsumer isn't used because it's retry semantics are hard-wired and aren't compatible with what care partner alerting's needs. Note: A proper implementation of AlertsEventsConsumer to consume events is yet to be written. It will follow shortly. BACK-2554
The upload id is necessary to ensure that only the proper device data uploads are evaluated for care partner alert conditions. BACK-2554
If the necessary configuration isn't found, then push notifications will instead be logged. BACK-2554
These methods return Note objects that can be sent as push notifications. NotLooping evaluation will be handled in a later commit. BACK-2554
It uses the new asyncevents from go-common, as alerts processing requires different retry semantics than the existing solution. The Pusher interface is moved out of data/service into data/events to avoid a circular dependency. BACK-2554
No longer needed
ewollesen
force-pushed
the
eric-cpa-not-looping
branch
from
0b7ee55 to
bb4ff02
Compare
BACK-2559
ewollesen
force-pushed
the
eric-cpa-not-looping
branch
from
bb4ff02 to
d57125d
Compare
ewollesen
force-pushed
the
eric-cpa-alerts
branch
from
967c617 to
cd42b19
Compare
ewollesen
force-pushed
the
eric-cpa-alerts
branch
2 times, most recently
from
9432468 to
eaa652e
Compare
ewollesen
force-pushed
the
eric-cpa-alerts
branch
from
d6449a1 to
ee5da4a
Compare
ewollesen
force-pushed
the
eric-cpa-alerts
branch
from
8ae1dc8 to
28fdf06
Compare
ewollesen
force-pushed
the
eric-cpa-alerts
branch
from
28fdf06 to
b9767dc
Compare
|
Worked out in another branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACK-2559
Needs #715 to merge first