Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump underscore to 1.13.6 #1336

Closed
wants to merge 4 commits into from

Conversation

caspahouzer
Copy link
Contributor

I've updated underscore.js to the latest version. I already using it in development over some time and all functionalities looking good for me

@caspahouzer caspahouzer requested review from ewanharris and m1ga May 14, 2022 07:25
@m1ga
Copy link
Contributor

m1ga commented May 14, 2022

1.13.3 is available https://underscorejs.org/#changelog
might want to update an run your tests again (looks like just a minor update that shouldn't affect any functionality)

@ewanharris ewanharris force-pushed the new-underscore-version branch from 8461a1d to 0a722e1 Compare January 8, 2024 21:57
@@ -1,6 +1,4 @@
//! moment.js locale configuration
//! locale : English (Singapore) [en-sg]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file keeps appearing and reappearing for me, will see what is actually correct

@ewanharris ewanharris changed the title bump version of underscore from 1.9.1 > 1.13.2 feat: bump underscore to 1.13.6 Jan 8, 2024
@ewanharris ewanharris force-pushed the new-underscore-version branch from aba6954 to c251507 Compare January 8, 2024 22:00
@ewanharris
Copy link
Contributor

I'm not sure what's going on with the en-sg file here after rebasing, I'll close this PR and reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants