Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALOY-1714] Allow ~/ to be used as a shortcut for WPATH() in xml view attributes #951

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

brentonhouse
Copy link
Contributor

@brentonhouse brentonhouse commented Jan 23, 2020

https://jira.appcelerator.org/browse/ALOY-1714

Allow ~/ be used as a shortcut for this so that WPATH() is no longer required when using with XML View attributes

<Alloy>
    <ImageView id="image" image="~/images/a.png" />
</Alloy>

@brentonhouse brentonhouse self-assigned this Jan 23, 2020
@build
Copy link

build commented Jan 23, 2020

Warnings
⚠️

Please ensure to add a changelog entry for your changes. Edit the CHANGELOG.md file and add your change under the Unreleased items header

Messages
📖

✅ All tests are passing
Nice one! All 3490 tests are passing.

Generated by 🚫 dangerJS against e1f51ba

Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're going to faces the same challenges as #953 here, this currently will only work in views. If we're adding syntactic sugar like this I'd rather see it work in the majority of places rather than a single one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants