Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove os:windows from config.json #957

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Remove os:windows from config.json #957

merged 1 commit into from
Mar 25, 2020

Conversation

Topener
Copy link
Contributor

@Topener Topener commented Mar 20, 2020

Removing os:windows from config.json due to dropping Windows support since SDK 9.0

@Topener Topener requested a review from ewanharris March 20, 2020 13:56
@build
Copy link

build commented Mar 20, 2020

Warnings
⚠️

Please ensure to add a changelog entry for your changes. Edit the CHANGELOG.md file and add your change under the Unreleased items header
Messages
📖

✅ All tests are passing
Nice one! All 3490 tests are passing.

Generated by 🚫 dangerJS against f6678ac

ewanharris
ewanharris approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewanharris ewanharris merged commit 63c13aa into master Mar 25, 2020
@ewanharris ewanharris deleted the Topener-patch-1 branch March 25, 2020 13:49
@ewanharris
Copy link
Contributor

I think we should also completely remove the Windows platform in #952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Topener @build @ewanharris