New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(all): remove ndk message, fix eslint warnings #629

Merged

cb1kenobi merged 1 commit into master from 221221_ndk_error

Jan 13, 2023

Contributor

m1ga commented Dec 21, 2022

should merge #598 first

remove some eslint warnings
remove ANDROID_NDK_NOT_FOUND warning (NDK is installed by the CLI since refactor(android): removed deprecated usage of "ndk.dir" titanium-sdk#12711)
add openjdk link to the "install jdk" message and fixed oracle jdk link
changing avd.js to include partiton-size and image only if it is set (fixes M1 Android black emulator issues)


          chore(all): remove ndk message, fix eslint warnings

0d03e50

m1ga mentioned this pull request

Open tickets tidev/titanium-sdk#13411

Open

m1ga mentioned this pull request

chore: default to ipv4 #637

Merged

cb1kenobi reviewed

View reviewed changes

Contributor

cb1kenobi left a comment

Reviewed, but didn't test (yet), and the changes look good. Waiting to merge until #598 has been merged.

cb1kenobi approved these changes

View reviewed changes

cb1kenobi merged commit 5708189 into master

m1ga deleted the 221221_ndk_error branch

February 2, 2023 10:39

m1ga mentioned this pull request

fix: arm mac emulator fix #652

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet