Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added image rotation functionality. Cleaned up repository to improve builds. #15

Merged
merged 5 commits into from
May 7, 2017

Conversation

collinprice
Copy link
Contributor

No description provided.

@jwogan5
Copy link

jwogan5 commented May 26, 2016

@collinprice

Hi collin,

Is there anyway you could build your module into a distribution zip with these changes. I really need the image rotation changes. I'm building an app and on android portrait images are showing as landscape.

@ashcoding
Copy link
Contributor

@jwogan5
This seems like an old PR. Not sure how fast the author will reply but you could make this into a distribution zip on your own based on this guide http://docs.appcelerator.com/platform/latest/#!/guide/Android_Module_Project

@jwogan5
Copy link

jwogan5 commented May 27, 2016

@ashcoding

Thanks for the link to the documentation. I haven't built a module yet but im looking forward to using the doc to build some other modules. I actually did find the link to collins build of 2.3.1 and it works great.

https://github.com/collinprice/ti.imagefactory/releases

@collinprice
Copy link
Contributor Author

Great to hear @jwogan5

@julien9999
Copy link

how to rotate an image ?
thanks

@jwogan5
Copy link

jwogan5 commented Sep 19, 2016

@julien9999

I am using an exif js file to get the rotation needed to flip the image correctly. Here is the code not including that library that I am using to rotate images.

var rotate = 90; // Just a sample rotate integer degree.
var rotatedImage = ImageFactory.imageWithRotation(e.media, {degrees: rotate});

@julien9999
Copy link

any chance you can share the exif js file with me and logic to use it ?
thanks

@jwogan5
Copy link

jwogan5 commented Sep 19, 2016

Here is a gist I just created with the exif.js file and a sample.js file:
https://gist.github.com/jwogan5/24d622a7f670ab57fcf983ab3ff2ecd8

@julien9999
Copy link

awesome thanks ! working great

@hansemannn
Copy link
Contributor

@collinprice Hey man! I think it's about time to integrate this :-) Can you resolve the merge conflicts or should one of our devs help?

@collinprice
Copy link
Contributor Author

@hansemannn Yay! I resolved the merge conflicts but it looks like travis failed for a different reason.

@hansemannn
Copy link
Contributor

hansemannn commented May 7, 2017

Merging now and will adjust the version and changelog afterwards. Thank you @collinprice! :-)

@hansemannn hansemannn merged commit 0ef7127 into tidev:stable May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants