NSNumber * vs NSInteger #12218
Merged
NSNumber * vs NSInteger #12218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests:
|
theoretically this should avoid crash
theoretically this should avoid crash
sgtcoolguy
force-pushed
the
nsnumber-nsinteger
branch
from
61d95e4 to
decac8e
Compare
garymathews
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This grew out of taking a second look at @jquick-axway 's #12193 and @garymathews #12029
I couldn't cause a crash by re-enabling the related tests for the properties, so the fixes here are sort of speculative. But it looks like maybe they'd be useful to Gary's PR since he's intentionally disabling the tests that hit these properties again.