Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promise fixes #12416

Merged
merged 10 commits into from
Jan 26, 2021
Merged

Promise fixes #12416

merged 10 commits into from
Jan 26, 2021

Conversation

sgtcoolguy
Copy link
Contributor

Description:
Attempting to extract fixes/refactorings necessary for #12349 and #12407 to work (basically bugfixes/internal API changes that "muddy" the other PRs original aims of making certain existing APIs return `Promises).

@sgtcoolguy
fix(ios): expose KrollPromise as part of TitaniumKit
cd95e4d
@sgtcoolguy
refactor(ios): add rejectWithErrorMessage method for KrollPromise
1bcd40c
@sgtcoolguy
build: add script to find candidate methods for returning Promise
e70599f
@sgtcoolguy
fix(ios): convert JSValue* to JSValueRef directly
26a5fb4
@sgtcoolguy
fix(ios): convert KrollPromise to JSValueRef for return types of old …
e41f17e 
…proxies
@sgtcoolguy
fix(ios): have KrollPromise static methods return instancetype, not J…
d7cf653 
…SValue*
@sgtcoolguy
refactor(ios): add method to expose current JSContext for TiProxy ins…
5ce4ca7 
…tances
@sgtcoolguy
fix(ios): make JSValue nonatomic property, retain it under the hood, …
8f2710e 
…handle exception in creation
@sgtcoolguy
fix(ios): autorelease Ti.Blob#arrayBuffer() Promise
a59e7e3
@sgtcoolguy
fix(ios): make KrollPromise no-op under covers when KrollFinalizer is…
1035757 
… running to avoid crash

* when finalizing don't even try to generate error object from context
@build build added this to the 10.0.0 milestone Jan 26, 2021
@build build requested a review from a team January 26, 2021 18:43
@build
Copy link
Contributor

build commented Jan 26, 2021

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
🚫 Tests have failed, see below for more information.
Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 1 tests have failed There are 1 tests failing and 976 skipped out of 16636 total tests.

Tests:

ClassnameNameTimeError
ios.macos.Titanium.Blobimage dimensions should be reported in pixels (10.15.5)0.009
Error: expected 6 to be 11
value@file:///node_modules/should/cjs/should.js:356:23
postlayout@file:///ti.blob.test.js:483:33

Generated by 🚫 dangerJS against 1035757

@sgtcoolguy sgtcoolguy merged commit b3aaaa3 into tidev:master Jan 26, 2021
@sgtcoolguy sgtcoolguy deleted the promise-fixes branch January 26, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ios needs tests 🚨
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sgtcoolguy @build