-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking change] Android: Ti.UI.Color parity #13273
base: master
Are you sure you want to change the base?
Conversation
|
FYI: The reason we didn't add For example, your changes would break the following... The backward compatible solution that we implemented embeds both dark/light color values into a single string when calling Anyways, that's my 2 cents. This March, you guys can handle this anyway you want. If you want to move forward with this, then my recommendation is to do this in a new Titanium 11.0.0 release and force everyone to rebuild their modules. |
Thanks @jquick-axway, I'm glad you are still with us. |
Very impressive PR! So thrilled to get this reviewed and merged when TiDev can take over. |
1aa43ad
to
fda1f98
Compare
@drauggres A few merge conflicts to resolve here, but no time pressure as it's for 11.0.0 (targeted for September) anyways. |
- "Ti.UI.fetchSemanticColor" returns "Ti.UI.Color" - Support "Ti.UI.Color" instances for components properties fix tidev#13272
47e84ff
to
3fcdbda
Compare
This happened bacause this PR had to include commits from #13267 and #13265 and they were "merged" with rebase, i.e. not really merged (in git terms) but copies of the commits were created. I rebased my branch, should be fine now. |
@m1ga And this one as well |
Ti.UI.fetchSemanticColor
returnsTi.UI.Color
Ti.UI.Color
instances for components propertiesThis PR includes commit from #13267 and #13265
Fix #13272
Read this before merging.