chore: fix packages #13780
Merged
chore: fix packages #13780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since there wasn't any feedback about the (the 1 failed should be the clipboard test, depending on the emulator version it works or not) |
|
cb1kenobi
approved these changes
Mar 30, 2023
narbs
pushed a commit
to narbs/titanium_mobile
that referenced
this pull request
Jun 7, 2023
* chore: fix packages * chore: use fix package versions * chore: fix tableview test * revert test + tableview post * chore: add new node-titanium-sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after weeks of testing I found that babel was the issue and some other packages that are newer now when you remove the package-lock file.
Resolves #13778
Attention
Merge this first: tidev/node-titanium-sdk#649 - after that I'll update the version number in this PR for the node-titanium-sdk package- mergedLog
Full log in https://tidev.slack.com/archives/C038J3D6M4Y/p1679688501001629?thread_ts=1675721718.383329&cid=C038J3D6M4Y
Info
Removing e.g.
core-js-compator updating to babel7.12.*will result in thecallsite {}issues. Had to add babel/core and types in here so it will force this version. Starting to put the package version info into #13781Fixed version
I went ahead and used fixed version in the package.json file! Test suite runs fine besides the "TableView" issue (check slack).Cannot call this method in a scroll callbackfix from fix(android): tableView fixes #13768Tested two apps (one external), test suite, hyperloop examples, module build
Follow up
we should use fixed versions for the node packages to make it future prove and use only packages we want it to useThis way we can finally create a 12.1.0 in my opinion. After that we can continue to update node packages, the current versions are the same as 12.0.0 (especially babel).