fix: (iOS) Fix app freezing when trying to hide & show popover repeatedly and popover layout issues

[AhmedMSayed]

Fixes 13915

Sample

const win = Ti.UI.createWindow();

const hidePopover = Ti.UI.createButton({
	title: 'Hide Popover',
	backgroundColor: 'orange',
	width: 160,
	height: 40
});
hidePopover.addEventListener("click", (e) => {
	popover.hide();
});

const showPopover = Ti.UI.createButton({
	title: "Show Popover",
	backgroundColor: 'red',
	width: 120,
	height: 40
});

showPopover.addEventListener("click", (e) => {
	const popoverWin = Ti.UI.createWindow({
		backgroundColor: 'red',
		title: 'Popover Window',
		rightNavButton: hidePopover
	});

	const listView = Ti.UI.createListView({
		backgroundColor: 'blue',
	});
	const sections = [];

	const fruitDataSet = [
		{ properties: { title: 'Apple' } },
		{ properties: { title: 'Banana' } },
	];
	const fruitSection = Ti.UI.createListSection({ headerTitle: 'Fruits', items: fruitDataSet });
	sections.push(fruitSection);

	const vegDataSet = [
		{ properties: { title: 'Carrots' } },
		{ properties: { title: 'Potatoes' } },
	];
	const vegSection = Ti.UI.createListSection({ headerTitle: 'Vegetables', items: vegDataSet });
	sections.push(vegSection);

	listView.sections = sections;

	popoverWin.add(listView);

	const fishDataSet = [
		{ properties: { title: 'Cod' } },
		{ properties: { title: 'Haddock' } },
	];
	const fishSection = Ti.UI.createListSection({ headerTitle: 'Fish', items: fishDataSet });
	listView.appendSection(fishSection);

	const popoverNav = Ti.UI.createNavigationWindow({
		window: popoverWin
	});

	popover = Ti.UI.iPad.createPopover({
		contentView: popoverNav
	});

	popover.show({ view: showPopover });
});

win.add(showPopover);

win.open();

[hansemannn]

Some quick questions, but nothing blocking.

[hansemannn]

@AhmedMSayed Can you please sign the CLA? Then we're good to go! @cb1kenobi what's the website again? 😇

[AhmedMSayed]

@AhmedMSayed Can you please sign the CLA? Then we're good to go! @cb1kenobi what's the website again? 😇

Sure just tell me how

[cb1kenobi]

@AhmedMSayed Huge thanks for the contribution! Please read https://github.com/tidev/organization-docs/blob/main/AUTHORIZED_CONTRIBUTORS.md, then fire off an email or ping Josh to send you a Docusign link. Apologies for the hassle.

[hansemannn]

@AhmedMSayed @joshualambert This is the last blocker for the 12.2.1. If you folks can handle the CLA today, we can release the version 😊

[AhmedMSayed]

@hansemannn I see new issue when presenting popover from modal window
I fixed it by present popover from topPresentedController, I tested it again and it works

[hansemannn]

Now only the CLA is pending and then we can merge and release 12.2.1!

[AhmedMSayed]

Already talked to Josh and signed in docusign, didn't know what i can do next

[cb1kenobi]

I pinged Josh. He needs to verify it's been signed and update https://github.com/tidev/organization-docs/blob/main/AUTHORIZED_CONTRIBUTORS.md.

[cb1kenobi]

Awesome, thanks @AhmedMSayed!