-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make android mocha tests run again #14158
base: master
Are you sure you want to change the base?
Conversation
…-sdk into fixAndroidTestXML
@prashantsaini1 maybe you can check this one too. Then the testsuite will run again ( Just a note: there are still around 10 tests that fail in the emulator, but the outher thousand of tests run fine 😄 |
This one's fine as I already noticed at other places that |
I was wondering why the Android mocha tests weren't running anymore. Turns out: the generated tiapp.xml was invalid. There was a missing
>
and it had two<application>
(we have a default one in the template now) nodes.Fixing some tests:
headerTitle/footerTitle is not working (even with 12.5.0) so disabling that for the moment- Fixed in fix(android): fix global header/footer title in ListView #14160Interesting point:
tableView.deleteRow(tableView.sections[0].rows[2]);
is not working in the emulator but on a device it is working fine 🤷 That's one test that is still failing but couldn't fix it yet.