fix(build): restore old scons dependencies to fix local Xcode build #14168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow, this took me a bit to debug. So here is what's going on: 48afddf updated several dependencies (good!), but broke the local iOS build via Xcode that is used to debug the iOS source code.
The reason why it broke is that we have a pre-compile script to generate the ti.kernel and index.json that are need for internal bootstraping of the iOS source. This generator uses
ssriandfs-extrato do some file i/o. The updated packages introduced optional chaining that is not supported by the Xcode runtime, so it broke the pre-compiler. Restoring these two dependencies to their initial values solved it, while we check for a solution that can handle optional chaining in the future.