fix #717: tile38_expired_keys and several other metrics not returned #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expired_keys never incremented additional metrics not returned from metrics endpoint
undeadcat
force-pushed
the
bugfix-expired-metric-not-returned
branch
from
7e566f2 to
c78c8b4
Compare
|
I'm good with your code as-is. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure you adhere to every item in this list
Describe your changes
statsExpiredwas never incrementedtile38_expired_keysand some other metrics (seems liketile38_total_messages_sent) were never returned becauseint64values were never handled int Prometheus endpoint (metrics.go).This is my first PR here and in Go. Apologies if something is not typical or idiomatic :-)
Feel free to close and rewrite if easier :-) Mostly wanted to illustrate the cause of the issue, as I understand it.
Issue number and link
Fixes #717