Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glmnet tests on usage of data descriptors #84

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Mar 15, 2023

These tests are part of addressing tidymodels/parsnip#878

Context: I think we can remove parsnip::eval_args(). It uses parsnip:::maybe_eval() which has a comment that the reason for its existence is related to parsnip's data descriptors.

The goal of this PR is to

  • have tests that cover the use of descriptors with glmnet engines,
  • show that they pass, and
  • then show that they still pass after we remove usage of eval_args() in parsnip and extensions.

@topepo Is there any other usage of the descriptors you had in mind?

@hfrick hfrick requested a review from topepo March 15, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants