quantile regression updates for new hardhat model #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed and reopened to trigger CI for |
added 9 commits
September 23, 2024 13:43
hfrick
approved these changes
Sep 25, 2024
| @@ -8,7 +8,7 @@ on: | |||
| push: | |||
| branches: [main, master] | |||
| pull_request: | |||
| branches: [main, master] | |||
There was a problem hiding this comment.
I'm commenting on this so that we have a TODO marker for undoing this change when we are ready to merge.
| @@ -4,7 +4,7 @@ on: | |||
| push: | |||
| branches: [main, master] | |||
| pull_request: | |||
| branches: [main, master] | |||
Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
topepo
added a commit
that referenced
this pull request
Oct 11, 2024
* add a quantile regression mode to test with * update type checkers * avoid confusion with global all_models object * add quantile_level argument to set_mode() * initial data for quantreg * some initial tests * fix some issues * enable quantile prediction * tests for quantreg * Quantile predictions output constructor (#1191) * small change to predict checks * add vctrs for quantiles and test, refactor *_rq_preds * revise tests * Apply some of the suggestions from code review Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com> * rename tests on suggestion from code review * export missing funs from vctrs for formatting * convert errors to snapshot tests * pass call through input check * update snapshots for caller_env * rename to parsnip_quantiles, add format snapshot tests * Apply suggestions from @topepo Co-authored-by: Max Kuhn <mxkuhn@gmail.com> * rename parsnip_quantiles to quantile_pred * rename parsnip_quantiles to quantile_pred and add vector probability check * fix: two bugs introduced earlier * add formatting tests for single quantile * replace walk with a loop to avoid "Error in map()" * remove row/col names * adjust quantile_pred format * as_tibble method * updated NEWS file * add PR number * small new update * helper methods * update docs * re-enable quantiles prediction for #1203 * update some tests * no longer needed * use tibble::new_tibble * braces * test as_tibble * remove print methods --------- Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com> Co-authored-by: Max Kuhn <mxkuhn@gmail.com> Co-authored-by: ‘topepo’ <‘mxkuhn@gmail.com’> * quantile regression updates for new hardhat model (#1207) * bump hardhat version * remove parts now in hardhat * update for new hardhat version * quantile_levels (plural now) * news update * typo * rename helper function * run CI on PRs from branches * forgotten remote * actions for edited PRs * plural * expand branch list * export function for censored to use * updated snapshot * remake snapshot * Revert "remake snapshot" This reverts commit 954e326. * updated snapshot * Update R/arguments.R Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com> * typo * changes from reviewer feedback --------- Co-authored-by: ‘topepo’ <‘mxkuhn@gmail.com’> Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com> * Change to `quantile` argument to `quantile levels` (#1208) * quantile -> quantile_levels for #1203 * defer test until censored updates in new PR * update docs for quantile_levels * update test * disable quantile predictions for surv_reg --------- Co-authored-by: ‘topepo’ <‘mxkuhn@gmail.com’> * post conflict merge updates * update news * version bump and fix typo * revert GHA branches * small bug fix * Apply suggestions from code review Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com> Co-authored-by: Emil Hvitfeldt <emil.hvitfeldt@posit.co> * don't export median * add call arg * added documentation on model * add mode * convert error to warning * remove rankdeficient * added skip * add deprecated `quantile` arg back in * remove numeric prediction --------- Co-authored-by: ‘topepo’ <‘mxkuhn@gmail.com’> Co-authored-by: Daniel McDonald <dajmcdon@gmail.com> Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com> Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com> Co-authored-by: Emil Hvitfeldt <emil.hvitfeldt@posit.co>
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on hardhat >= 1.4.0.9002.
The main update is that the hardhat code is standardized on the plural
quantile_levels.