Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NEWS bullet #870

Closed
EmilHvitfeldt opened this issue Mar 15, 2024 · 1 comment · Fixed by #871
Closed

Update NEWS bullet #870

EmilHvitfeldt opened this issue Mar 15, 2024 · 1 comment · Fixed by #871

Comments

@EmilHvitfeldt
Copy link
Member

In #863 we changed the way the dots work. But it also breaks select_best() which we don't explicitly mention. I think we should mention this breakage as well as I used it a few times

library(tune)

data("example_ames_knn")

# Both used to work

select_best(ames_iter_search, "rmse")
#> Error in `select_best()`:
#> ! `...` must be empty.
#> ✖ Problematic argument:
#> • ..1 = "rmse"
#> ℹ Did you forget to name an argument?

select_best(ames_iter_search, metric = "rmse")
#> # A tibble: 1 × 6
#>       K weight_func dist_power   lon   lat .config              
#>   <int> <chr>            <dbl> <int> <int> <chr>                
#> 1    33 triweight        0.511    10     3 Preprocessor10_Model1

Created on 2024-03-15 with reprex v2.1.0

Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant