require optional arguments to be named #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those dots are actually passed on to internal functions and aren't just to enforce naming arguments.
simonpcouch
added a commit
to tidymodels/finetune
that referenced
this pull request
Feb 29, 2024
This was referenced Feb 29, 2024
EmilHvitfeldt
approved these changes
Feb 29, 2024
|
Wow, tidysdm is the only revdep breakage, and it's not due to these changes. Right on. :) |
simonpcouch
added a commit
to tidymodels/finetune
that referenced
this pull request
Mar 1, 2024
* address issues from tidymodels/tune#863 * move dots in `collect_*()` * move dots in `show_best.tune_race()` note that this adds a `call` argument for compatibility with the `tune_results` method--otherwise, tune will add one when calling `show_best()` inside of `select_best()` and trigger a nonempty dots error * note change in NEWS * update Remotes ref * pass `type` by name preserves the previous behavior of respecting `type`; this is already tested in extratests * update tune ref [no ci]
Closed
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From
NEWS:Note that these changes also apply to some other functions that hadn't yet made it to the CRAN version of the package.
Creating as draft as there are many changes here and I'd want to take another look + look into extratests + get started on analogous changes downstream in finetune and agua before calling this ready for review. If you see issues already, though, feel free to chime in.