address issues from tidymodels/tune#863

tidymodels · Feb 29, 2024 · 47f4137 · 47f4137
1 parent 7bbb18f
commit 47f4137
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/R/racing_helpers.R b/R/racing_helpers.R
@@ -670,7 +670,7 @@ collect_predictions.tune_race <-
  all_configs = FALSE,
  ...) {
  x <- dplyr::select(x, -.order)
- res <- NextMethod(summarize = summarize, parameters = parameters)
+ res <- collect_predictions(x, summarize = summarize, parameters = parameters)
  if (!all_configs) {
  final_configs <- subset_finished_race(x)
  res <- dplyr::inner_join(res, final_configs, by = ".config")
@@ -684,7 +684,7 @@ collect_predictions.tune_race <-
 collect_metrics.tune_race <- function(x, summarize = TRUE, all_configs = FALSE, ...) {
  x <- dplyr::select(x, -.order)
  final_configs <- subset_finished_race(x)
- res <- NextMethod(summarize = summarize, ...)
+ res <- collect_metrics(x, summarize = summarize)
  if (!all_configs) {
  final_configs <- subset_finished_race(x)
  res <- dplyr::inner_join(res, final_configs, by = ".config")

diff --git a/R/tune_race_anova.R b/R/tune_race_anova.R
@@ -303,8 +303,8 @@ tune_race_anova_workflow <-
 
  opt_metric_time <- tune::first_eval_time(
  metrics,
- opt_metric_name,
- eval_time,
+ metric = opt_metric_name,
+ eval_time = eval_time,
  call = call
  )
 

diff --git a/R/tune_race_win_loss.R b/R/tune_race_win_loss.R
@@ -283,8 +283,8 @@ tune_race_win_loss_workflow <-
 
  opt_metric_time <- tune::first_eval_time(
  metrics,
- opt_metric_name,
- eval_time,
+ metric = opt_metric_name,
+ eval_time = eval_time,
  call = call
  )
 

diff --git a/R/tune_sim_anneal.R b/R/tune_sim_anneal.R
@@ -344,8 +344,8 @@ tune_sim_anneal_workflow <-
  eval_time <- tune::check_eval_time_arg(eval_time, metrics, call = call)
  opt_metric_time <- tune::first_eval_time(
  metrics,
- opt_metric_name,
- eval_time,
+ metric = opt_metric_name,
+ eval_time = eval_time,
  call = call
  )